Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to hide in which headers the struct is defined #725

Closed
wants to merge 1 commit into from

Conversation

rhssk
Copy link
Contributor

@rhssk rhssk commented Aug 12, 2021

When something like "doxygennamespace" is used, structures gain
additional line about in which header they are defined.

If the API simply serves as a generic description and no public headers
are provided, this info is redundant. This can be worked around
manually by using "doxygenstruct" directive instead, but this can get
messy quickly with large namespaces. Also, namespace description is
lost.

Allow to hide these lines by setting 'breathe_show_struct_include' to
'False'. The default behavior stays unchanged.

Fixes #57.

@vermeeren vermeeren self-assigned this Sep 18, 2021
@vermeeren vermeeren self-requested a review September 18, 2021 01:27
@vermeeren vermeeren added code Source code enhancement Improvements, additions (also cosmetics) labels Sep 18, 2021
Copy link
Collaborator

@jakobandersen jakobandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for renaming to breathe_show_include made as suggestions in Github.

breathe/directives.py Outdated Show resolved Hide resolved
breathe/renderer/sphinxrenderer.py Outdated Show resolved Hide resolved
documentation/source/directives.rst Outdated Show resolved Hide resolved
documentation/source/directives.rst Outdated Show resolved Hide resolved
documentation/source/directives.rst Outdated Show resolved Hide resolved
documentation/source/directives.rst Outdated Show resolved Hide resolved
documentation/source/directives.rst Outdated Show resolved Hide resolved
@rhssk
Copy link
Contributor Author

rhssk commented Sep 20, 2021

Updated with the requested changes.

When something like "doxygennamespace" is used, structures gain
additional line about in which header they are defined.

If the API simply serves as a generic description and no public headers
are provided, this info is redundant. This can be worked around by
manually by using "doxygenstruct" directive instead, but this can get
messy quickly with large namespaces. Also, namespace description is
lost.

Allow to hide these lines by setting 'breathe_show_include' to
'False'. The default behavior stays unchanged.

See breathe-doc#57.
@rhssk
Copy link
Contributor Author

rhssk commented Sep 20, 2021

And rebased on master

@2bndy5 2bndy5 mentioned this pull request Nov 17, 2021
@2bndy5
Copy link
Contributor

2bndy5 commented Nov 18, 2021

@rhssk Can you rebase this branch on master?

@jakobandersen @vermeeren It looks like all requested changes were applied. Any further objections to merging this (after rebase is done)?

@jakobandersen
Copy link
Collaborator

Thanks! Merged via rebase (87c6ca1 + parent).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Source code enhancement Improvements, additions (also cosmetics)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected include in the documentation of struct within a namespace
4 participants